Review Request 126954: [Notifications] Fix Job finished persistency
Kai Uwe Broulik
kde at privat.broulik.de
Mon Feb 1 21:02:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 9:02 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Martin Klapetek.
Changes
-------
Submitted with commit bec916168c269df8807678c61aeb551cc3aac10e by Kai Uwe Broulik to branch master.
Repository: plasma-workspace
Description
-------
This was an oversight when porting to call the dataengine for that notification.
Diffs
-----
applets/notifications/package/contents/ui/Jobs.qml 669d0bd
dataengines/notifications/notificationaction.cpp c2da498
Diff: https://git.reviewboard.kde.org/r/126954/diff/
Testing
-------
Works now.
KNotificationDBusTest also works fine.
Plasma Undo notifications are no longer persistent but this is unrelated to this patch.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/5e140b68/attachment.html>
More information about the Plasma-devel
mailing list