Review Request 126954: [Notifications] Fix Job finished persistency

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/#review91890
-----------------------------------------------------------


Ship it!




Thanks

- Martin Klapetek


On Feb. 1, 2016, 9:39 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126954/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 9:39 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This was an oversight when porting to call the dataengine for that notification.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/Jobs.qml 669d0bd 
>   dataengines/notifications/notificationaction.cpp c2da498 
> 
> Diff: https://git.reviewboard.kde.org/r/126954/diff/
> 
> 
> Testing
> -------
> 
> Works now.
> 
> KNotificationDBusTest also works fine.
> 
> Plasma Undo notifications are no longer persistent but this is unrelated to this patch.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/45141397/attachment.html>