[Differential] [Commented On] D3809: Use new xkbcommon API for consumed modifiers

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D3809#72205, @graesslin wrote:
  
  > In https://phabricator.kde.org/D3809#72177, @kfunk wrote:
  >
  > > This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?
  >
  >
  > No it's not. Do you think I'm not aware of the fact that this will create a hassle?
  
  
  Well, I was surprised to see the version bump for this seemingly trivial change, thus I asked. Is it not possible to conditionally compile in some code based on the XKB version instead? "No it's not" isn't a satisfying explanation.
  
  I'm asking because I see more and more code bases in KDE requiring too-bleeding-edge software (hint: our kdepim stack), with all the consequences this has -- of which you're surely aware of.
  
  >> Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.
  > 
  > Yes I know exactly when it was released. It was released also because *I* requested it.
  
  
  
  In https://phabricator.kde.org/D3809#72205, @graesslin wrote:
  
  > In https://phabricator.kde.org/D3809#72177, @kfunk wrote:
  >
  > > This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it possible to stay compatible with XKB 0.5.0 for some more time?
  >
  >
  > No it's not. Do you think I'm not aware of the fact that this will create a hassle?
  >
  > > Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago.
  >
  > Yes I know exactly when it was released. It was released also because *I* requested it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3809

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: kfunk, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161230/c13f31db/attachment.html>