[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

[kossebau (Friedrich W. H. Kossebau)]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kdeplatformfiledialoghelper.cpp:368
> This does NOT build for me.
> 
> qplatformdialoghelper.h:295:5: error: ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private
> kdeplatformfiledialoghelper.cpp:368:77: error: within this context
> kdeplatformfiledialoghelper.cpp:368:77: error: use of deleted function ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’
> 
> Qt 5.8 git, gcc 4.8.
> 
> I am not sure why Q_DISABLE_COPY(QFileDialogOptions) is used, sounds like the right fix is to add support for copying and moving to these classes in Qt; but short term this might mean doing the copy by hand (calling 20 setters, sucks). It is curious however that it built for you?

Seems the code needs to be adapted to have a variant for the changes introduced by this commit:
http://code.qt.io/cgit/qt/qtbase.git/commit/src/gui/kernel/qplatformdialoghelper.h?id=1a421248396e4b2bdc9ff3ebb63b1edf41c93474
so be for that version

  QSharedPointer<QFileDialogOptions> opt = options()->clone();

Could you give that a try? I only have Qt from my distro packages, which is Qt 5.7.0

I am not used to browsing of Qt branches and sadly cannot spot from http://code.qt.io/cgit/qt/qtbase.git/log/src/gui/kernel/qplatformdialoghelper.h at which version this is added.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3796

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, #plasma, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161223/8079f7b2/attachment.html>