[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

[dfaure (David Faure)]

dfaure added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:368
> +    // like file://, so we have to do it ourselves
> +    QSharedPointer<QFileDialogOptions> opt(new QFileDialogOptions(*options()));
> +    opt->setInitialDirectory(m_dialog->directory());

This does NOT build for me.

qplatformdialoghelper.h:295:5: error: ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private
kdeplatformfiledialoghelper.cpp:368:77: error: within this context
kdeplatformfiledialoghelper.cpp:368:77: error: use of deleted function ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’

Qt 5.8 git, gcc 4.8.

I am not sure why Q_DISABLE_COPY(QFileDialogOptions) is used, sounds like the right fix is to add support for copying and moving to these classes in Qt; but short term this might mean doing the copy by hand (calling 20 setters, sucks). It is curious however that it built for you?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3796

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, #plasma, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161223/c20640e7/attachment-0001.html>