[Differential] [Accepted] D3707: add simple test rig for service runner

[dfaure (David Faure)]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> servicerunnertest.cpp:49
> +    QDir(appsPath).removeRecursively();
> +    Q_ASSERT(QDir().mkpath(appsPath));
> +    auto fixtureDir = QDir(QFINDTESTDATA("fixtures"));

Use QVERIFY rather than Q_ASSERT in unittests.

(better integrated with the framework, and works even in a release build)

(replace all Q_ASSERTs in this file, there are others)

> servicerunnertest.cpp:54
> +        auto target = appsPath + QDir::separator() + fileInfo.fileName();
> +        Q_ASSERT_X(QFile::copy(fileInfo.absoluteFilePath(), target),
> +                   "copy",

QVERIFY2

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3707

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik, dfaure
Cc: dfaure, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161222/1dac4410/attachment.html>