<table><tr><td style="">dfaure accepted this revision.<br />dfaure added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3707" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3707#inline-15027" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">servicerunnertest.cpp:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QDir</span><span class="p">(</span><span class="n">appsPath</span><span class="p">).</span><span class="n">removeRecursively</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">QDir</span><span class="p">().</span><span class="n">mkpath</span><span class="p">(</span><span class="n">appsPath</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">auto</span> <span class="n">fixtureDir</span> <span style="color: #aa2211">=</span> <span class="n">QDir</span><span class="p">(</span><span class="n">QFINDTESTDATA</span><span class="p">(</span><span style="color: #766510">"fixtures"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use QVERIFY rather than Q_ASSERT in unittests.</p>

<p style="padding: 0; margin: 8px;">(better integrated with the framework, and works even in a release build)</p>

<p style="padding: 0; margin: 8px;">(replace all Q_ASSERTs in this file, there are others)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3707#inline-15026" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">servicerunnertest.cpp:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">auto</span> <span class="n">target</span> <span style="color: #aa2211">=</span> <span class="n">appsPath</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">fileInfo</span><span class="p">.</span><span class="n">fileName</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">Q_ASSERT_X</span><span class="p">(</span><span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">copy</span><span class="p">(</span><span class="n">fileInfo</span><span class="p">.</span><span class="n">absoluteFilePath</span><span class="p">(),</span> <span class="n">target</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                   <span style="color: #766510">"copy"</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QVERIFY2</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3707" rel="noreferrer">https://phabricator.kde.org/D3707</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>sitter, broulik, dfaure<br /><strong>Cc: </strong>dfaure, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>