[Differential] [Abandoned] D3736: Initialise m_volume in VolumeObject

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Dec 19 17:50:19 UTC 2016


davidedmundson abandoned this revision.
davidedmundson added a comment.


  In https://phabricator.kde.org/D3736#69877, @drosca wrote:
  
  > Perhaps it would be better to use `pa_cvolume_init`? In this case it really doesn't matter, but invalid volume value (for `pa_cvolume::values`) is not zero, but `UINT32_MAX`.
  
  
  Oh, that would be a million times better.
  
  There's also a pa_cvolume_equal instead of the original memcmp.
  
  Will redo.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: drosca, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/28b7ebb8/attachment.html>


More information about the Plasma-devel mailing list