<table><tr><td style="">davidedmundson abandoned this revision.<br />davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3736" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3736#69877" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D3736#69877</a>, <a href="https://phabricator.kde.org/p/drosca/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@drosca</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Perhaps it would be better to use <tt style="background: #ebebeb; font-size: 13px;">pa_cvolume_init</tt>? In this case it really doesn't matter, but invalid volume value (for <tt style="background: #ebebeb; font-size: 13px;">pa_cvolume::values</tt>) is not zero, but <tt style="background: #ebebeb; font-size: 13px;">UINT32_MAX</tt>.</p></div>
</blockquote>
<p>Oh, that would be a million times better.</p>
<p>There's also a pa_cvolume_equal instead of the original memcmp.</p>
<p>Will redo.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3736" rel="noreferrer">https://phabricator.kde.org/D3736</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>drosca, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>