[Differential] [Commented On] D3714: Enable blurBehind effect if the window hints for it

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added inline comments.

INLINE COMMENTS

> graesslin wrote in kwaylandintegration.cpp:35
> just wondering: we once have here a QByteArray and once a const char[] - shouldn't we use the same in both?

I used char[] for consistency with the old code, but I can use QByteArray if you prefer

> graesslin wrote in kwaylandintegration.cpp:85-87
> What about the variant being false? Shouldn't we check the value and then either enable/disable the blur behind?
> 
> Also should we support changes at runtime? Not saying we should, just asking ;-)

> What about the variant being false? Shouldn't we check the value and then either enable/disable the blur behind?

Maybe we should do it when the property is valid but false? If we do it when the property is invalid/unset I think we could break something?

> Also should we support changes at runtime? Not saying we should, just asking ;-)

I'm not sure about this, but if one doesn't want the blur effect they can disable the property before showing the tooltip. This should be enough, I suppose (maybe worth a note it in the tooltip's apidox though).

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3714

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161219/d3135c10/attachment.html>