[Differential] [Commented On] D3714: Enable blurBehind effect if the window hints for it

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> kwaylandintegration.cpp:35
>  static const QByteArray s_schemePropertyName = QByteArrayLiteral("KDE_COLOR_SCHEME_PATH");
> +static const QByteArray s_blurBehindPropertyName = QByteArrayLiteral("ENABLE_BLUR_BEHIND_HINT");
>  

just wondering: we once have here a QByteArray and once a const char[] - shouldn't we use the same in both?

> kwaylandintegration.cpp:85-87
> +                if (w->property(s_blurBehindPropertyName.constData()).toBool()) {
> +                    KWindowEffects::enableBlurBehind(w->winId(), true);
> +                }

What about the variant being false? Shouldn't we check the value and then either enable/disable the blur behind?

Also should we support changes at runtime? Not saying we should, just asking ;-)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3714

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161218/803d99e0/attachment.html>