[Differential] [Request, 2 lines] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

sitter (Harald Sitter) noreply at phabricator.kde.org
Fri Dec 16 12:39:35 UTC 2016


sitter created this revision.
sitter added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KService::noDisplay() includes qualification for
  
  - NoDisplay entry itself
  - OnlyShowIn and NotShowIn
  - X-KDE-OnlyShowOnQtPlatforms
  - authorization WRT KCMs
  
  as such checking nodisplay is good enough to disqualify services in all
  relevant scenarios

TEST PLAN
  - read the code of noDisplay()

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3705

AFFECTED FILES
  runners/services/servicerunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161216/c403d092/attachment-0001.html>


More information about the Plasma-devel mailing list