<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: broulik.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3705" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>KService::noDisplay() includes qualification for</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">NoDisplay entry itself</li>
<li class="remarkup-list-item">OnlyShowIn and NotShowIn</li>
<li class="remarkup-list-item">X-KDE-OnlyShowOnQtPlatforms</li>
<li class="remarkup-list-item">authorization WRT KCMs</li>
</ul>

<p>as such checking nodisplay is good enough to disqualify services in all<br />
relevant scenarios</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">read the code of noDisplay()</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3705" rel="noreferrer">https://phabricator.kde.org/D3705</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/services/servicerunner.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>sitter, broulik<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>