[Differential] [Request, 54 lines] D3688: [Runners] Register actions right away

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Dec 15 16:41:03 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Previously, they were created on-demand, which was the wrong approach, I think.
  Kicker checks for actions() being available before it even bothers getting actions for a match.

TEST PLAN
  I now get runner actions in Kickoff for search results.
  F743618: Screenshot_20161215_173627.png <https://phabricator.kde.org/F743618>
  F743649: Spectacle.M20286.png <https://phabricator.kde.org/F743649>
  
  Verified that:
  
  - shell runner still runs applications and run in terminal still works, both in KRunner and Kickoff
  - calculator runner still invokes result and copy to clipboard, in KRunner
  - recent docs runner still opens files and open containing folder action still works, both in KRunner and Kickoff
  - baloo runner still opens files and open containing folder action still works, both in KRunner and Kickoff

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3688

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/calculator/calculatorrunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/176efff1/attachment-0001.html>


More information about the Plasma-devel mailing list