<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, Plasma: Design, hein.<br />broulik set the repository for this revision to R120 Plasma Workspace.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3688" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Previously, they were created on-demand, which was the wrong approach, I think.<br />
Kicker checks for actions() being available before it even bothers getting actions for a match.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I now get runner actions in Kickoff for search results.<br />
<a href="https://phabricator.kde.org/F743618" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F743618: Screenshot_20161215_173627.png</a><br />
<a href="https://phabricator.kde.org/F743649" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F743649: Spectacle.M20286.png</a></p>
<p>Verified that:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">shell runner still runs applications and run in terminal still works, both in KRunner and Kickoff</li>
<li class="remarkup-list-item">calculator runner still invokes result and copy to clipboard, in KRunner</li>
<li class="remarkup-list-item">recent docs runner still opens files and open containing folder action still works, both in KRunner and Kickoff</li>
<li class="remarkup-list-item">baloo runner still opens files and open containing folder action still works, both in KRunner and Kickoff</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3688" rel="noreferrer">https://phabricator.kde.org/D3688</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/baloo/baloosearchrunner.cpp<br />
runners/calculator/calculatorrunner.cpp<br />
runners/recentdocuments/recentdocuments.cpp<br />
runners/shell/shellrunner.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, Plasma: Design, hein<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>