[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

[hein (Eike Hein)]

hein added a comment.


  Marco: Yeah I agree it's fugly. The constructor was originally added for atomicity and then it grew ove time. Let's refactor separately from this maybe though?

INLINE COMMENTS

> broulik wrote in wheelinterceptor.cpp:52
> Is this for another patch?
> 
> Also, you lose pixel-precise scrolling here

Forgot to mention this one in the description. It's used by the Simple Menu UI code to do page flips (hence pixel-precision is also not needed).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3655

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161213/6943ed54/attachment.html>