[Differential] [Changed Subscribers] D2613: Fix some status notifier items not appearing

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> statusnotifieritemsource.cpp:85
> +    //when it gets data with a new key it tries to update the  QAIM roleNames
> +    //from QML this achieves absolutely nothing as there is no signal to tell QQmlDelegateModel to reload the roleNames in QQmlAdapatorModel
> +    //no matter if the row changes or the model refreshes

Wrong indentation

> statusnotifieritemsource.cpp:90
> +    //by setting everything up-front so that we have all role names when we call the first checkForUpdate()
> +    setData(QStringLiteral("AttentionIcon"), QString());
> +    setData(QStringLiteral("AttentionIconName"), QString());

AttentionIcon is a QIcon

> statusnotifieritemsource.cpp:94
> +    setData(QStringLiteral("Category"), QString());
> +    setData(QStringLiteral("Icon"), QString());
> +    setData(QStringLiteral("IconName"), QString());

This is also a QIcon

> statusnotifieritemsource.cpp:106
> +    setData(QStringLiteral("ToolTipChanged"), false);
> +    setData(QStringLiteral("ToolTipIcon"), QString());
> +    setData(QStringLiteral("ToolTipSubTitle"), QString());

This apparently can be both QString and QIcon...

> statusnotifieritemsource.cpp:111
> +
> +
> +

Two superfluous empty lines

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2613

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160830/ee324e07/attachment.html>