[Differential] [Request, 29 lines] D2615: Don't load the system tray containment via two different code paths
davidedmundson (David Edmundson)
noreply at phabricator.kde.org
Sun Aug 28 13:04:00 UTC 2016
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We have everything we need in Applet::init there is no need to sometimes
load it then, sometimes in UiReadyConstraint especially as it then
requires further hacks on the QML side to manage that.
Should be faster, cleaner and also fixes a warning about binding a layout to a null Item.
TEST PLAN
Loaded plasmashell with my config
Loaded plasmashell after deleting my config
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2615
AFFECTED FILES
applets/systemtray/container/package/contents/ui/main.qml
applets/systemtray/container/systemtraycontainer.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160828/ec8facdd/attachment.html>
More information about the Plasma-devel
mailing list