Review Request 128751: Don't rely on manual emit of QObject::destroyed before the object is destroyed

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128751/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

It's wrong, and leads to more bodges elsewhere.

Note:
Some code in plasma-workspace is relying on the wrong behaviour (or
rather working round it). The full fix up can't be merged without breaking old plasma releases.


Diffs
-----

  src/plasma/applet.h 449f761d37b6f435f8311504e1d9c618a8588e6d 
  src/plasma/corona.h 07ad2849bcd97a38ec62d412fd845a0363bcbd55 
  src/plasma/corona.cpp 7ff64cd5f69234197b603de015f6a06a7303e12e 
  src/plasma/private/applet_p.cpp b0f9edb56b6e85e85080945bf8038cd70b7698af 
  src/plasma/private/corona_p.h d556baf362c138c8418a69204fd987ab35a283a5 

Diff: https://git.reviewboard.kde.org/r/128751/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160825/cc92ca89/attachment.html>