<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128751/">https://git.reviewboard.kde.org/r/128751/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's wrong, and leads to more bodges elsewhere.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note:
Some code in plasma-workspace is relying on the wrong behaviour (or
rather working round it). The full fix up can't be merged without breaking old plasma releases.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/applet.h <span style="color: grey">(449f761d37b6f435f8311504e1d9c618a8588e6d)</span></li>
<li>src/plasma/corona.h <span style="color: grey">(07ad2849bcd97a38ec62d412fd845a0363bcbd55)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(7ff64cd5f69234197b603de015f6a06a7303e12e)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(b0f9edb56b6e85e85080945bf8038cd70b7698af)</span></li>
<li>src/plasma/private/corona_p.h <span style="color: grey">(d556baf362c138c8418a69204fd987ab35a283a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128751/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>