[Differential] [Request, 562 lines] D2553: [effects] Drop the logout effect

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Wed Aug 24 08:09:29 UTC 2016


graesslin created this revision.
graesslin added reviewers: KWin, Plasma, VDG.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The new logout design doesn't want to have the vignetting. Thus the
  logout effect itself doesn't make any sense any more. All that would
  still be used is the logout blur which can also be provided by the
  blur effect nowadays for fullscreen windows. As the new logout is a
  fullscreen window it should use that one.
  
  The logout effect did one more thing: it kept the vignetting and the
  blur once the user selected logout. Now without the vignetting this
  would be weird and again doesn't make much sense any more.
  
  So overall I think it's better to just drop the logout effect and use
  blur effect in normal way. Neat side advantage: it will also work on
  Wayland out-of-the-box.

REPOSITORY
  rKWIN KWin

BRANCH
  drop-logout-effect

REVISION DETAIL
  https://phabricator.kde.org/D2553

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/logout/CMakeLists.txt
  effects/logout/data/1.10/vignetting.frag
  effects/logout/data/1.40/vignetting.frag
  effects/logout/logout.cpp
  effects/logout/logout.h
  effects/logout/logout.kcfg
  effects/logout/logoutconfig.kcfgc
  effects/shaders.qrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, #vdg
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160824/0460dc84/attachment.html>


More information about the Plasma-devel mailing list