<table><tr><td style="">graesslin created this revision.<br />graesslin added reviewers: KWin, Plasma, VDG.<br />Restricted Application added a project: KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2553" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The new logout design doesn't want to have the vignetting. Thus the<br />
logout effect itself doesn't make any sense any more. All that would<br />
still be used is the logout blur which can also be provided by the<br />
blur effect nowadays for fullscreen windows. As the new logout is a<br />
fullscreen window it should use that one.</p>

<p>The logout effect did one more thing: it kept the vignetting and the<br />
blur once the user selected logout. Now without the vignetting this<br />
would be weird and again doesn't make much sense any more.</p>

<p>So overall I think it's better to just drop the logout effect and use<br />
blur effect in normal way. Neat side advantage: it will also work on<br />
Wayland out-of-the-box.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>drop-logout-effect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2553" rel="noreferrer">https://phabricator.kde.org/D2553</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/test_builtin_effectloader.cpp<br />
autotests/test_plugin_effectloader.cpp<br />
effects/CMakeLists.txt<br />
effects/effect_builtins.cpp<br />
effects/effect_builtins.h<br />
effects/logout/CMakeLists.txt<br />
effects/logout/data/1.10/vignetting.frag<br />
effects/logout/data/1.40/vignetting.frag<br />
effects/logout/logout.cpp<br />
effects/logout/logout.h<br />
effects/logout/logout.kcfg<br />
effects/logout/logoutconfig.kcfgc<br />
effects/shaders.qrc</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas<br /></div>