Review Request 128707: Add support for captive portals
Sebastian Kügler
sebas at kde.org
Thu Aug 18 11:08:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98462
-----------------------------------------------------------
kded/service.cpp (line 49)
<https://git.reviewboard.kde.org/r/128707/#comment66348>
PortalMonitor is not known when webengine support is off at build time
kded/service.cpp (line 86)
<https://git.reviewboard.kde.org/r/128707/#comment66349>
This would also need a an #if (or you can make webengine required dep, of course)
- Sebastian Kügler
On Aug. 18, 2016, 10:58 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 10:58 a.m.)
>
>
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
>
>
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.
>
>
> Diffs
> -----
>
> CMakeLists.txt a27c1f2
> kded/CMakeLists.txt 1f0613e
> kded/portalmonitor.h PRE-CREATION
> kded/portalmonitor.cpp PRE-CREATION
> kded/service.cpp 18ffd41
>
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
>
>
> Testing
> -------
>
> Tested with three different captive portals and it worked perfectly.
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/6260a267/attachment.html>
More information about the Plasma-devel
mailing list