Review Request 128707: Add support for captive portals

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
-----------------------------------------------------------

(Updated Srp. 18, 2016, 10:58 dop.)


Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.


Changes
-------

Fixes mentioned issues.

I'm just not sure about my usage of QScopedPointer as I have never used it before. I removed initialization/deinitialization of m_view pointer in connectivityChanged() slot and I just show it or hide it instead.


Bugs: 365417
    http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
-------

Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.


Diffs (updated)
-----

  CMakeLists.txt a27c1f2 
  kded/CMakeLists.txt 1f0613e 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
-------

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/76e9ca23/attachment.html>