Review Request 127744: [taskmanager] ToolTipDelegate Dragon fix

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127744/#review94861
-----------------------------------------------------------



Stripping the reverse domain name is a no-no. The way this is done in the patch even more so.

This was briefly discussed on #plasma, I'll just dump my suggestion from there here:

The way this should work is by employing matching heuristics to match our launcherUlr to the correct mpris interface in the following order:
- mpris.DesktopEntry() == basename(launcherUrl)  # this will be true for the majority of native apps
- mpris.Identity() == KDesktopFile(launcherUrl).name  # this is a pretty name match, which is naughty as those can be !english, but assuming they come from the desktop file this might still work
- dbusaddress(mpris).split('.')[-1] == basename(launcherUrl).split('.')[-1]   # last ditch effort employing what we have right now where the last part of the dbus address needs to match the last part of the desktop file (disregarding RDN)

The overall conclusion however was that the matching should be centered around the DesktopEntry() as it is the most reliable way to identify the application the window belongs to. All additional matching logic would ultimatly just be a fuzzy-match fallback in case DesktopEntry() is not implemented by the application

- Harald Sitter


On April 25, 2016, 6:01 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127744/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 6:01 p.m.)
> 
> 
> Review request for KDE Multimedia, Plasma, Kai Uwe Broulik, and Harald Sitter.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> So if you have better fix, please tell me. I saw KService::desktopEntryName() it's do it in same way
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kservice/html/kservice_8cpp_source.html#l00153
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 383c4a4 
> 
> Diff: https://git.reviewboard.kde.org/r/127744/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160425_205140.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/0f053160-11ef-411e-8bae-9c08e79f20aa__Screenshot_20160425_205140.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160426/9f7ad055/attachment.html>