<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127744/">https://git.reviewboard.kde.org/r/127744/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Stripping the reverse domain name is a no-no. The way this is done in the patch even more so.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This was briefly discussed on #plasma, I'll just dump my suggestion from there here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The way this should work is by employing matching heuristics to match our launcherUlr to the correct mpris interface in the following order:
- mpris.DesktopEntry() == basename(launcherUrl) # this will be true for the majority of native apps
- mpris.Identity() == KDesktopFile(launcherUrl).name # this is a pretty name match, which is naughty as those can be !english, but assuming they come from the desktop file this might still work
- dbusaddress(mpris).split('.')[-1] == basename(launcherUrl).split('.')[-1] # last ditch effort employing what we have right now where the last part of the dbus address needs to match the last part of the desktop file (disregarding RDN)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The overall conclusion however was that the matching should be centered around the DesktopEntry() as it is the most reliable way to identify the application the window belongs to. All additional matching logic would ultimatly just be a fuzzy-match fallback in case DesktopEntry() is not implemented by the application</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On April 25th, 2016, 6:01 p.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia, Plasma, Kai Uwe Broulik, and Harald Sitter.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated April 25, 2016, 6:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So if you have better fix, please tell me. I saw KService::desktopEntryName() it's do it in same way
http://api.kde.org/frameworks-api/frameworks5-apidocs/kservice/html/kservice_8cpp_source.html#l00153</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: grey">(383c4a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127744/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/0f053160-11ef-411e-8bae-9c08e79f20aa__Screenshot_20160425_205140.png">Screenshot_20160425_205140.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>