Review Request 127467: PulseObject: Add iconName property

Mon Apr 25 08:52:12 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/#review94828
-----------------------------------------------------------

Ship it!

Ship It!

- Kai Uwe Broulik

On April 12, 2016, 8:01 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127467/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 8:01 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Add iconName property to PulseObject and use it in KCM and applet.
> Devices in KCM now shows proper icons and streams in applet now have icons.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a40b996 
>   applet/contents/ui/StreamListItem.qml 7e84505 
>   src/CMakeLists.txt 3fef329 
>   src/kcm/package/contents/ui/CardListItem.qml cfc41e3 
>   src/kcm/package/contents/ui/DeviceListItem.qml 1752d3d 
>   src/kcm/package/contents/ui/StreamListItem.qml b12e3f3 
>   src/pulseobject.h f41ed72 
>   src/pulseobject.cpp c46a063 
>   src/qml/CMakeLists.txt 9d021fc 
>   src/qml/ClientIcon.qml 8256758 
>   src/qml/qmldir de44fca 
> 
> Diff: https://git.reviewboard.kde.org/r/127467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160425/d1518bcc/attachment.html>