Review Request 127467: PulseObject: Add iconName property

David Rosca nowrep at gmail.com
Tue Apr 12 20:01:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/
-----------------------------------------------------------

(Updated April 12, 2016, 8:01 p.m.)


Review request for Plasma.


Summary (updated)
-----------------

PulseObject: Add iconName property


Repository: plasma-pa


Description (updated)
-------

Add iconName property to PulseObject and use it in KCM and applet.
Devices in KCM now shows proper icons and streams in applet now have icons.


Diffs (updated)
-----

  CMakeLists.txt a40b996 
  applet/contents/ui/StreamListItem.qml 7e84505 
  src/CMakeLists.txt 3fef329 
  src/kcm/package/contents/ui/CardListItem.qml cfc41e3 
  src/kcm/package/contents/ui/DeviceListItem.qml 1752d3d 
  src/kcm/package/contents/ui/StreamListItem.qml b12e3f3 
  src/pulseobject.h f41ed72 
  src/pulseobject.cpp c46a063 
  src/qml/CMakeLists.txt 9d021fc 
  src/qml/ClientIcon.qml 8256758 
  src/qml/qmldir de44fca 

Diff: https://git.reviewboard.kde.org/r/127467/diff/


Testing (updated)
-------


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160412/bea1d2c7/attachment.html>


More information about the Plasma-devel mailing list