Review Request 126953: Remove Theme Details KCM

[Michał Dybczak]

> On Kwi 5, 2016, 7:37 rano, Luigi Toscano wrote:
> > Refraining from personal comments, there is a question related to this regarding the documentation:
> > 
> > https://mail.kde.org/pipermail/kde-doc-english/2016-April/013341.html
> > 
> > I would add: is there a document that explain how to achive the same (create a theme, possibly inheriting the base from existing themes)? Is this enough? https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails

I'm actually devastaed by that change. The feature was a bit buggy but still one was able to achive desired effects. I was able to change kde inside (how it works) and outside (how it looks) but now the half of it is kiled :/.
KDE is loosing it's identity :(
Why someone who is not using cetain feature thinks that others do the same or assumes that others hate it too? Please, fix it, change it but bring it back!

See the discussion:
https://bugs.kde.org/show_bug.cgi?id=359127


- Michał


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/#review94271
-----------------------------------------------------------


On Lut 7, 2016, 11:15 po południu, Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126953/
> -----------------------------------------------------------
> 
> (Updated Lut 7, 2016, 11:15 po południu)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This removes the theme editor thing in the Desktop Theme KCM.
> 
> Most settings in there are either broken or useless nowadays.
> 
> The only setting I would miss is different Analog Clock faces which could be done in the Analog Clock directly. What I am missing in general is a custom Panel color/texture or something like that which we don't have in here anyway.
> 
> 
> Diffs
> -----
> 
>   kcms/desktoptheme/CMakeLists.txt 6168686 
>   kcms/desktoptheme/DesktopTheme.ui f57cdf8 
>   kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
>   kcms/desktoptheme/desktopthemedetails.h 475d893 
>   kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
>   kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
>   kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
>   kcms/desktoptheme/kcmdesktoptheme.h ac87862 
>   kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
>   kcms/desktoptheme/thememodel.cpp bb5bb94 
> 
> Diff: https://git.reviewboard.kde.org/r/126953/diff/
> 
> 
> Testing
> -------
> 
> Tab gone.
> 
> While at it I also replaced the status label with a proper KMessageWidget
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160409/4842c6b2/attachment.html>