[Differential] [Request, 1 line] D1338: Fix null values in currency conversion

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We would check if the string (unit1) matched any known units (s) using a
  case insensitve compare.
  
  If it did, we would treat that as a valid unit and pass it on to
  KUnitConversion, but unfortunately that is case senstive, and then fails
  to find anything.
  
  This fixes the case of the user typed unit to be correct.

TEST PLAN
  Ran krunner with "640 gbp in eur" it now returns the same as "640 GBP 
  in EUR" . 
  debug in kunitconversion shows it now has a valid unit ID for the first 
  query.
  (the result is still utterly wrong, but it's one problem less)

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1338

AFFECTED FILES
  runners/converter/converterrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160407/f4296078/attachment-0001.html>