<div>davidedmundson created this revision.<br />
davidedmundson added a reviewer: Plasma.<br />
Restricted Application added a project: Plasma.<br />
Restricted Application added a subscriber: plasma-devel.</div><br /><div><strong>REVISION SUMMARY</strong><div><p>We would check if the string (unit1) matched any known units (s) using a<br />
case insensitve compare.</p>
<p>If it did, we would treat that as a valid unit and pass it on to<br />
KUnitConversion, but unfortunately that is case senstive, and then fails<br />
to find anything.</p>
<p>This fixes the case of the user typed unit to be correct.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Ran krunner with "640 gbp in eur" it now returns the same as "640 GBP <br />
in EUR" . <br />
debug in kunitconversion shows it now has a valid unit ID for the first <br />
query.<br />
(the result is still utterly wrong, but it's one problem less)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEPLASMAADDONS Plasma Addons</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1338" rel="noreferrer">https://phabricator.kde.org/D1338</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/converter/converterrunner.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, sebas<br /></div>