Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125395/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 11:08 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Daniel Nicoletti and Harald Sitter.


Changes
-------

Submitted with commit 29247d6d19c49a20c17ea414a0e108905712a520 by David Edmundson to branch Applications/15.08.


Repository: print-manager


Description
-------

m_connectedEvents is modified in connectNotify which according to the
docs will be called from the thread of the caller, not this.

A mutex around all places that use/modify it should prevent print manager from making plasmashell crash.

BUG: 345862


Diffs
-----

  libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66 
  libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6 

Diff: https://git.reviewboard.kde.org/r/125395/diff/


Testing
-------

Applet still loads..though I don't have any printers, so can't test too much.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150930/6e9af835/attachment.html>