Review Request 125395: Mutex around usage of m_connectedEvents which may be called from any thread

[Daniel Nicoletti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125395/#review86139
-----------------------------------------------------------

Ship it!


Oh I missed the queued call to timer->start(), so it indeed is better, since afaik queued calls also require mutexes I first though that having to lookup the matching slot and having a mutex either way could at least avoid that the meta lookup... Thanks for the patch :)

- Daniel Nicoletti


On Set. 29, 2015, 3:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125395/
> -----------------------------------------------------------
> 
> (Updated Set. 29, 2015, 3:48 p.m.)
> 
> 
> Review request for Plasma, Daniel Nicoletti and Harald Sitter.
> 
> 
> Repository: print-manager
> 
> 
> Description
> -------
> 
> m_connectedEvents is modified in connectNotify which according to the
> docs will be called from the thread of the caller, not this.
> 
> A mutex around all places that use/modify it should prevent print manager from making plasmashell crash.
> 
> BUG: 345862
> 
> 
> Diffs
> -----
> 
>   libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66 
>   libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6 
> 
> Diff: https://git.reviewboard.kde.org/r/125395/diff/
> 
> 
> Testing
> -------
> 
> Applet still loads..though I don't have any printers, so can't test too much.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150930/defa0ca9/attachment-0001.html>