Review Request 125453: introduce SkipsTaskbar

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125453/#review86141
-----------------------------------------------------------


general note: in KWin it's called "skipTaskbar" also in the NET classes it's SkipTaskbar. I suggest we keep that and drop the s.

Another general note: in the commit message you have a typo: t instead of s.

- Martin Gräßlin


On Sept. 29, 2015, 8:26 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125453/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 8:26 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> support the skiptTaskbar property in the window model
> that property is set client side by
> PlasmaShell::setSkipsTaskbar
> 
> 
> Diffs
> -----
> 
>   src/client/plasmashell.h 6692300f820daa44c9363143463dfb8433bcdddc 
>   src/client/plasmashell.cpp 4daaecffee9d45ebf4a783bfff9b33e9572fca22 
>   src/client/plasmawindowmanagement.h 6e36def79719a7115ea41189746f871f5ffc6e70 
>   src/client/plasmawindowmanagement.cpp f6279d9c470cd153b65bc13f0ee12d631a370b16 
>   src/client/plasmawindowmodel.h 49a211569cc5a8fe9ce237230a3acea0f8e5f384 
>   src/client/plasmawindowmodel.cpp ceba6ce8fa75d565e4ace435d08446b604b58bc4 
>   src/client/protocols/plasma-shell.xml 7d33236dae6cf9571e98b8ccef6b377f76a7d99f 
>   src/client/protocols/plasma-window-management.xml a5bd639299a1e1af587f46369e4388eae02382c4 
>   src/server/plasmashell_interface.h 228cbb1965da72d3dd73a1e73d97c04a80bc0b78 
>   src/server/plasmashell_interface.cpp 32fd38906c3c55c678af40786ae6061465732046 
>   src/server/plasmawindowmanagement_interface.h c348d653882d3bc66d81679d05b1886d388aa32a 
>   src/server/plasmawindowmanagement_interface.cpp d6c71ae0584cf12b1ae89cae0948d66b7b349e4c 
> 
> Diff: https://git.reviewboard.kde.org/r/125453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150930/0ea1b74a/attachment.html>