<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125453/">https://git.reviewboard.kde.org/r/125453/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">general note: in KWin it's called "skipTaskbar" also in the NET classes it's SkipTaskbar. I suggest we keep that and drop the s.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Another general note: in the commit message you have a typo: t instead of s.</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On September 29th, 2015, 8:26 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2015, 8:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">support the skiptTaskbar property in the window model
that property is set client side by
PlasmaShell::setSkipsTaskbar</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/client/plasmashell.h <span style="color: grey">(6692300f820daa44c9363143463dfb8433bcdddc)</span></li>
<li>src/client/plasmashell.cpp <span style="color: grey">(4daaecffee9d45ebf4a783bfff9b33e9572fca22)</span></li>
<li>src/client/plasmawindowmanagement.h <span style="color: grey">(6e36def79719a7115ea41189746f871f5ffc6e70)</span></li>
<li>src/client/plasmawindowmanagement.cpp <span style="color: grey">(f6279d9c470cd153b65bc13f0ee12d631a370b16)</span></li>
<li>src/client/plasmawindowmodel.h <span style="color: grey">(49a211569cc5a8fe9ce237230a3acea0f8e5f384)</span></li>
<li>src/client/plasmawindowmodel.cpp <span style="color: grey">(ceba6ce8fa75d565e4ace435d08446b604b58bc4)</span></li>
<li>src/client/protocols/plasma-shell.xml <span style="color: grey">(7d33236dae6cf9571e98b8ccef6b377f76a7d99f)</span></li>
<li>src/client/protocols/plasma-window-management.xml <span style="color: grey">(a5bd639299a1e1af587f46369e4388eae02382c4)</span></li>
<li>src/server/plasmashell_interface.h <span style="color: grey">(228cbb1965da72d3dd73a1e73d97c04a80bc0b78)</span></li>
<li>src/server/plasmashell_interface.cpp <span style="color: grey">(32fd38906c3c55c678af40786ae6061465732046)</span></li>
<li>src/server/plasmawindowmanagement_interface.h <span style="color: grey">(c348d653882d3bc66d81679d05b1886d388aa32a)</span></li>
<li>src/server/plasmawindowmanagement_interface.cpp <span style="color: grey">(d6c71ae0584cf12b1ae89cae0948d66b7b349e4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>