Review Request 125437: Made new applet icons for all applets

Marco Martin notmart at gmail.com
Mon Sep 28 18:33:33 UTC 2015


On Monday 28 September 2015, andreas kainz wrote:
> > On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote:
> > > applets/showActivityManager/package/metadata.desktop, line 114
> > > <https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file40860
> > > 7line114>
> > > 
> > >     The applet icons aren't really part of the icon theme, but the icon
> > >     spec does say "As a further restriction, all icon names may only
> > >     contain lowercase letters, numbers, underscore, dash, or period
> > >     characters." - maybe we should keep the lowercase restriction for
> > >     our icon assets? It's not a big deal though.
> 
> should I remove the org.kde.? I would prefere icon names like
> 
> plasma-showactivitymanager
> 
> according to our wiki
> https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categor
> ization-guidelines-in-Breeze

fine with me, in that case is perhaps better to have 
plasma-applet-showactivitymanager
to be really sure all names won't clash with something else some day

-- 
Marco Martin


More information about the Plasma-devel mailing list