Review Request 125437: Made new applet icons for all applets

[andreas kainz]

> On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote:
> > applets/showActivityManager/package/metadata.desktop, line 114
> > <https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file408607line114>
> >
> >     The applet icons aren't really part of the icon theme, but the icon spec does say "As a further restriction, all icon names may only contain lowercase letters, numbers, underscore, dash, or period characters." - maybe we should keep the lowercase restriction for our icon assets? It's not a big deal though.

should I remove the org.kde.? I would prefere icon names like 

plasma-showactivitymanager

according to our wiki https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categorization-guidelines-in-Breeze


- andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125437/#review86049
-----------------------------------------------------------


On Sept. 28, 2015, 2:33 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125437/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 2:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Hi,
> 
> I made for all widgets applet icons in 256 px so that the user can see how the widget should look like in the future. will fit into the widget explorer.
> 
> when the widgets will work for you I made them for plasma-breeze-dark and maybe for plasma-oxygen (maybe)
> 
> The icon will be used in the widget-explorer sidebar and at use alternative widget, .... 
> 
> https://git.reviewboard.kde.org/r/125135/
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/metadata.desktop fbaabbc 
>   applets/kicker/package/metadata.desktop a6e7d7a 
>   applets/kickoff/package/metadata.desktop d9c9a3c 
>   applets/pager/package/metadata.desktop 148601e 
>   applets/showActivityManager/package/metadata.desktop 3295a1b 
>   applets/taskmanager/package/metadata.desktop e3b2f4b 
>   applets/window-list/metadata.desktop a532d45 
> 
> Diff: https://git.reviewboard.kde.org/r/125437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150928/8af8c8e3/attachment-0001.html>