Review Request 125411: kcm_keyboard: Enable selection in Advanced options view

David Rosca nowrep at gmail.com
Sat Sep 26 20:15:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125411/
-----------------------------------------------------------

(Updated Sept. 26, 2015, 8:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit e03136cd11083e78347c90b4f42dcaf17c390a24 by David Rosca to branch Plasma/5.4.


Bugs: 346948
    https://bugs.kde.org/show_bug.cgi?id=346948


Repository: plasma-desktop


Description
-------

Enable selection in Advanced options view to allow keyboard navigation.

Also fixed one wrong cast - possible crash.


Diffs
-----

  kcms/keyboard/kcm_keyboard.ui 53974e0 
  kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 
  kcms/keyboard/kcm_view_models.h 872e261 

Diff: https://git.reviewboard.kde.org/r/125411/diff/


Testing
-------

Selection + keyboard navigation works fine.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/9d8a8b82/attachment.html>


More information about the Plasma-devel mailing list