Review Request 125411: kcm_keyboard: Enable selection in Advanced options view

David Edmundson david at davidedmundson.co.uk
Sat Sep 26 17:57:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125411/#review85987
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 26, 2015, 4:36 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125411/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 4:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346948
>     https://bugs.kde.org/show_bug.cgi?id=346948
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Enable selection in Advanced options view to allow keyboard navigation.
> 
> Also fixed one wrong cast - possible crash.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/kcm_keyboard.ui 53974e0 
>   kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 
>   kcms/keyboard/kcm_view_models.h 872e261 
> 
> Diff: https://git.reviewboard.kde.org/r/125411/diff/
> 
> 
> Testing
> -------
> 
> Selection + keyboard navigation works fine.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/57147f0b/attachment.html>


More information about the Plasma-devel mailing list