Review Request 125118: [Icon widget] support dropping onto folder

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125118/#review85954
-----------------------------------------------------------

Ship it!


No objections from plasma devs so far -> ship it ;)


applets/icon/plugin/icon_p.cpp (line 110)
<https://git.reviewboard.kde.org/r/125118/#comment59311>

    Nitpick: Assert that dropEvent isn't a nullptr instead. (A drop without a drop event shouldn't happen, right? ;)


- Emmanuel Pescosta


On Sept. 9, 2015, 9:14 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125118/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 9:14 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This allows to drop file(s) onto a folder and have it ask whether to copy/move/link and brings up error dialogs if any.
> 
> 
> Diffs
> -----
> 
>   applets/icon/package/contents/ui/main.qml 49e91ca 
>   applets/icon/plugin/icon_p.h 5b0f752 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125118/diff/
> 
> 
> Testing
> -------
> 
> Dropping brings up the copy/move/paste dialog, copied, moved, and linked files, works. Confirmation dialogs are desktop modal. Also, I had to create my own QDropEvent from the declarative one.
> 
> Modifiers are broken but this is apparently a Qt bug, also I don't know whether my int cast to flags is right. Thanks Emmanuel for guiding me through this.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150926/9a3dbd48/attachment.html>