Review Request 125118: [Icon widget] support dropping onto folder

[Marco Martin]

> On Sept. 10, 2015, 6:54 p.m., Emmanuel Pescosta wrote:
> > applets/icon/plugin/icon_p.cpp, line 114
> > <https://git.reviewboard.kde.org/r/125118/diff/1/?file=402381#file402381line114>
> >
> >     A DeclarativeDropEvent::toQDropEvent() method maybe?

is the whole class that is not public, being in a QML plugin.

I'm a bit on the fence on that, but *maybe* a qproperty on it "nativeEvent" that has the actual qdropevent? (a bit scary tough)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125118/#review85130
-----------------------------------------------------------


On Sept. 9, 2015, 7:14 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125118/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 7:14 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This allows to drop file(s) onto a folder and have it ask whether to copy/move/link and brings up error dialogs if any.
> 
> 
> Diffs
> -----
> 
>   applets/icon/package/contents/ui/main.qml 49e91ca 
>   applets/icon/plugin/icon_p.h 5b0f752 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125118/diff/
> 
> 
> Testing
> -------
> 
> Dropping brings up the copy/move/paste dialog, copied, moved, and linked files, works. Confirmation dialogs are desktop modal. Also, I had to create my own QDropEvent from the declarative one.
> 
> Modifiers are broken but this is apparently a Qt bug, also I don't know whether my int cast to flags is right. Thanks Emmanuel for guiding me through this.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150911/f925f4ee/attachment.html>