Review Request 125327: kded_keyboard: Fix re-applying layout settings when plugging in new keyboard

[David Rosca]

> On Sept. 24, 2015, 8:43 p.m., David Edmundson wrote:
> > kcms/keyboard/layout_memory.cpp, line 131
> > <https://git.reviewboard.kde.org/r/125327/diff/1/?file=404839#file404839line131>
> >
> >     is this still true?

I'm not really sure. I can't find in history when this was added (it was before git) and why.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125327/#review85700
-----------------------------------------------------------


On Sept. 25, 2015, 7:41 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125327/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 7:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When adding a new keyboard, layout settings in X is reverted to default settings.
> This patch makes sure the layout settings in X remains the same as configured in kcm.
> 
> It does seem to be broken only when you are using Switching Policy != Global
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_config.h aff49a7 
>   kcms/keyboard/layout_memory.cpp 5ac6729 
>   kcms/keyboard/layouts_menu.cpp 630ed63 
> 
> Diff: https://git.reviewboard.kde.org/r/125327/diff/
> 
> 
> Testing
> -------
> 
> Plugged in new keyboard, layout settings remained the same as configured in kcm.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150925/7e94dd70/attachment.html>