Review Request 125327: kded_keyboard: Fix re-applying layout settings when plugging in new keyboard

David Edmundson david at davidedmundson.co.uk
Thu Sep 24 20:43:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125327/#review85700
-----------------------------------------------------------

Ship it!



kcms/keyboard/layout_memory.cpp (line 131)
<https://git.reviewboard.kde.org/r/125327/#comment59210>

    is this still true?


- David Edmundson


On Sept. 20, 2015, 6:04 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125327/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 6:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When adding a new keyboard, layout settings in X is reverted to default settings.
> This patch makes sure the layout settings in X remains the same as configured in kcm.
> 
> It does seem to be broken only when you are using Switching Policy != Global
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_config.h aff49a7 
>   kcms/keyboard/layout_memory.cpp 5ac6729 
>   kcms/keyboard/layouts_menu.cpp 630ed63 
> 
> Diff: https://git.reviewboard.kde.org/r/125327/diff/
> 
> 
> Testing
> -------
> 
> Plugged in new keyboard, layout settings remained the same as configured in kcm.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150924/dc9ce126/attachment.html>


More information about the Plasma-devel mailing list