Review Request 125277: Update recentApplicationCount in all places we modify applications list

[David Edmundson]

> On Sept. 18, 2015, 5:09 p.m., Marco Martin wrote:
> > fine, tough there should be a complete port of kickoff to kicker backend, that was delayed to not go in 5.4 at the last moment.
> > 
> > Eike: what's the status of it?
> 
> Eike Hein wrote:
>     It's pretty far along, but I currently have to work on some other things. Still planned for 5.5.

Is it pushed somewhere? I'd rather work on helping with that than spend time fixing kicker.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125277/#review85631
-----------------------------------------------------------


On Sept. 18, 2015, 6:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125277/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 6:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> hopefully fixes linked crash
> 
> BUG: 352047
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/recentlyusedmodel.cpp 27af6a595bfed97292b43be6df46528b1e79f038 
> 
> Diff: https://git.reviewboard.kde.org/r/125277/diff/
> 
> 
> Testing
> -------
> 
> Crash is in
> 
>     while (d->recentApplicationCount != 0) {
>         QList<QStandardItem *>items = takeRow(0);
>         
> which implies at some point d->recentApplicationCount got messed up somewhere, so did a code review on that.
> 
> Seems to still work.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/8ed4c806/attachment.html>