Review Request 125277: Update recentApplicationCount in all places we modify applications list
David Edmundson
david at davidedmundson.co.uk
Fri Sep 18 18:20:07 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125277/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 6:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit f808cd544ea60440d50d2835b0f57cd110519a98 by David Edmundson to branch Plasma/5.4.
Repository: plasma-desktop
Description
-------
hopefully fixes linked crash
BUG: 352047
Diffs
-----
applets/kickoff/core/recentlyusedmodel.cpp 27af6a595bfed97292b43be6df46528b1e79f038
Diff: https://git.reviewboard.kde.org/r/125277/diff/
Testing
-------
Crash is in
while (d->recentApplicationCount != 0) {
QList<QStandardItem *>items = takeRow(0);
which implies at some point d->recentApplicationCount got messed up somewhere, so did a code review on that.
Seems to still work.
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/f9d306fe/attachment.html>
More information about the Plasma-devel
mailing list