Review Request 125187: Stop requiring Frameworks 5.15

[David Faure]

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.

As you want. You're raising the bar for new contributors, who can't work on your code using the latest KDE Frameworks release.

You and me might compile everything, but you'll get more contributors if you let people work on workspace and apps using a released frameworks (for which there are distro packages) than if you require them to compile frameworks first. Just like we don't require Qt from git, we shouldn't require KF5 from git, I thought this was the general agreement.

If you're worried about the ifdef, just use the two liner version of the code forever, I was always a bit dubious about adding a method just for that anyway.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
-----------------------------------------------------------


On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 9:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased version of KDE Frameworks to build. David Faure has suggested to use fix like this one until at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -----
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/79e35ced/attachment.html>