Review Request 125187: Stop requiring Frameworks 5.15

Martin Gräßlin mgraesslin at kde.org
Mon Sep 14 08:44:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
-----------------------------------------------------------


-2, a change for a month in the devel branch doesn't make much sense.

- Martin Gräßlin


On Sept. 12, 2015, 11:38 a.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 11:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased version of KDE Frameworks to build. David Faure has suggested to use fix like this one until at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -----
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/7bb1c0e4/attachment.html>


More information about the Plasma-devel mailing list