Review Request 125190: Daemonize the forked kwalletd process.

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125190/#review85341
-----------------------------------------------------------

Ship it!


The change looks good.

- Àlex Fiestas


On set. 12, 2015, 10:37 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125190/
> -----------------------------------------------------------
> 
> (Updated set. 12, 2015, 10:37 a.m.)
> 
> 
> Review request for Plasma, Àlex Fiestas and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> -------
> 
> For example, if desktop is started by sddm,
> - for kwalletd5, it will be a subprocess of sddm-helper.
> - for kwalletd, there will be zombie subprocess of sddm-helper.
> 
> Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process.
> 
> 
> Diffs
> -----
> 
>   pam_kwallet.c a84585e 
> 
> Diff: https://git.reviewboard.kde.org/r/125190/diff/
> 
> 
> Testing
> -------
> 
> No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/6574a77d/attachment-0001.html>