Review Request 125190: Daemonize the forked kwalletd process.

Xuetian Weng wengxt at gmail.com
Sat Sep 12 10:37:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125190/
-----------------------------------------------------------

(Updated Sept. 12, 2015, 10:37 a.m.)


Review request for Plasma, Àlex Fiestas and Martin Klapetek.


Changes
-------

add mklapetek as reviewer


Repository: kwallet-pam


Description (updated)
-------

For example, if desktop is started by sddm,
- for kwalletd5, it will be a subprocess of sddm-helper.
- for kwalletd, there will be zombie subprocess of sddm-helper.

Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process.


Diffs
-----

  pam_kwallet.c a84585e 

Diff: https://git.reviewboard.kde.org/r/125190/diff/


Testing
-------

No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150912/7cf54279/attachment.html>


More information about the Plasma-devel mailing list