Review Request 125091: Speedup finding the property change signals

David Kahles david.kahles96 at gmail.com
Fri Sep 11 17:12:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125091/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 7:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-pa


Description
-------

We collected those signals in the constructor (initRoleNames) already,
so no need to iterate above them again. We can get the propertyChanged
Meta Method directly by it's name, we don't need to loop there either.


Diffs
-----

  src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad 

Diff: https://git.reviewboard.kde.org/r/125091/diff/


Testing
-------

Everything works as before.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150911/5a9d4013/attachment.html>


More information about the Plasma-devel mailing list